-
Notifications
You must be signed in to change notification settings - Fork 2
Exclude react from packages #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(it was including React in the bundle)
|
I also changed in components: From to |
|
Hyparquet demo: From to |
|
This is a great improvement in the bundle size! But, I would really prefer not to have hightable to take dependency on The problem is that we need some of the utils from hightable, mostly related to the DataFrame types and related utilities. And it seems like when we import from hightable, it's including more than just those utils? Are we not tree-shaking correctly? Or is it the fact that hightable has a peerDependency on react? This PR seems good but I don't want to approve until we understand what we're going to do with hightable deps. |
|
OK! I was wondering the same... Maybe it's a matter of tree-shaking that I didn't manage to make work (since we don't use React dependent code from hightable). I was also wondering at some point if hightable should be one of the @hyparam/components, as I see it as one of the main elements of the hyparam apps? But as per your comment above, I understand that you want to keep it independent, right? |
|
At the moment I think that hyparquet and hightable are the two components which i would like to keep separate from hyparam components. I think they are useful enough to stand on their own, and hopefully even get some community participation (already happening with hyparquet). I think that is more likely to happen if they are standalone projects not deeply tied to hyperparam components. Can you take a look at better tree-shaking? It would be nice to not have to duplicate
|
|
Yes, looking at it! |
|
it was that simple! #48 |
|
superseded by #48 |
I removed hightable dependency from utils: I think hightable should depend on @hyparam/utils instead.
See #46.
From
To
We still bundle hycompressors in the inlined worker, which explains >200kB