-
Notifications
You must be signed in to change notification settings - Fork 2
Add slide panel #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slide panel #82
Conversation
|
Should we re-open #23, and pass CSS modules with the components? |
|
|
||
| interface FileProps { | ||
| parsedKey: UrlKey | FileKey | ||
| parsedKey: UrlKey | FileKey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: interfaces don't require trailing commas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed! my bad. note that we sometimes use a ; and sometimes nothing (and sometimes a ,) and the three versions are accepted by eslint. I haven't found a rule in https://typescript-eslint.io/rules/, so... not sure what we can do to improve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I'm removing the commas, anyway)
platypii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, very minor nits, ran locally and confirmed that it works 👍 Users are excited to have this!

see #67
Note that I added a way to check the changes in dev mode:
See the demo folder.