Skip to content

Conversation

@severo
Copy link
Contributor

@severo severo commented Nov 25, 2024

see #67

Note that I added a way to check the changes in dev mode:

npm run dev

See the demo folder.

@severo
Copy link
Contributor Author

severo commented Nov 25, 2024

Should we re-open #23, and pass CSS modules with the components?

@severo severo marked this pull request as ready for review November 25, 2024 14:33
@severo severo requested a review from platypii November 25, 2024 14:33

interface FileProps {
parsedKey: UrlKey | FileKey
parsedKey: UrlKey | FileKey,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: interfaces don't require trailing commas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed! my bad. note that we sometimes use a ; and sometimes nothing (and sometimes a ,) and the three versions are accepted by eslint. I haven't found a rule in https://typescript-eslint.io/rules/, so... not sure what we can do to improve that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm removing the commas, anyway)

Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, very minor nits, ran locally and confirmed that it works 👍 Users are excited to have this!

@platypii
Copy link
Contributor

Also minor but the demo flashes a zero 0 on loading
Screenshot 2024-11-25 at 10 52 47

@platypii
Copy link
Contributor

Should we re-open #23, and pass CSS modules with the components?

Yea it's annoying copying CSS everywhere, I just don't know how to properly publish and incorporate into the downstream apps. I am in favor of re-opening #23 and let me know if you have ideas how to implement.

@severo severo merged commit 87b516b into master Nov 25, 2024
4 checks passed
@severo severo deleted the add-slide-panel branch November 25, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants