Feat/index sales value and other missing columns #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s columns to sales table - Introduced new columns to the sales table to store currency amounts, fee amounts as an array, and fee recipients as an array.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
bitbeckers
requested changes
Jan 26, 2025
Contributor
bitbeckers
left a comment
bitbeckers
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fast turnover. Added some comments. Especially for the script I think we should try to not allow any edge cases or unexpected behaviour to pass through.
…tails - Updated `parseTakerBidEvent` to include parsing of currency amount, fee amounts, and fee recipients. - Refactored transaction log handling to support HypercertExchange and ERC20 ABI. - Expanded `TakerBid` schema in `storeTakerBid` to accommodate new fields for currency and fees.
Jipperism
force-pushed
the
feat/index-sales-value-and-other-missing-columns
branch
from
9b75502 to
b7d2eeb
Compare
- this script will retroactively update existing rows in the sales table of supabase to contain fee_amounts, fee_recipients and currency_amount - it will also update any hypercert_id's that erronously ended up with an 'undefined' for the token ID
Jipperism
force-pushed
the
feat/index-sales-value-and-other-missing-columns
branch
from
b7d2eeb to
ba8c9ba
Compare
bitbeckers
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.