Revert "fix: publish beta releases to beta npm tag"#104
Revert "fix: publish beta releases to beta npm tag"#104aspiers merged 1 commit intohypercerts-org:developfrom
Conversation
This reverts commit a238d85 which didn't work. We'll just have to live with the bug that Changesets won't update the `beta` tag, only the `latest` tag. Hopefully this bug won't persist once we have a stable release.
|
📝 WalkthroughWalkthroughThe beta release workflow step in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release.yml (1)
129-137: Misleading comment about automatic beta tagging.The comment at lines 132-133 states that "changeset publish will automatically use the beta tag when in prerelease mode," but the PR description confirms this is not the case — Changesets only updates the
latesttag. This comment should be updated to reflect actual behavior and document the known limitation.📝 Suggested comment update
# Beta-specific: Publish beta packages using changeset publish - name: Publish beta packages if: env.RELEASE_TYPE == 'beta' - # changeset publish will automatically use the beta tag when in - # prerelease mode and will create git tags for the release + # NOTE: Changesets does not automatically publish to the beta npm tag + # in prerelease mode - it publishes to 'latest'. This is a known limitation + # that will be addressed once a stable release exists. + # See: https://github.com/hypercerts-org/hypercerts-lexicon/pull/104 run: npm run release
|
This fixed it. For the record, now releases yield: It's just a really stupid limitation of Changesets - it should be updating both dist tags not just |
This reverts commit a238d85 which didn't work. We'll just have to live with the bug that Changesets won't update the
betatag, only thelatesttag.Hopefully this bug won't persist once we have a stable release.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.