Add avatar and banner fields to collection lexicon#106
Conversation
🦋 Changeset detectedLatest commit: ab00bfc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: aspiers <100738+aspiers@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
@copilot Can you add that example you wrote to the README? |
Co-authored-by: aspiers <100738+aspiers@users.noreply.github.com>
|
Why not follow the same language as the bsky actor profile? |
|
@copilot Should we be using |
We're already using Current constraints:
Bluesky's
The union type approach also allows URI references as an alternative to embedded blobs, which Bluesky doesn't support. If you'd prefer to match Bluesky's constraints more closely, I can update the implementation.
The implementation follows the existing pattern in this codebase rather than Bluesky's approach. Looking at The terminology differs slightly: we use "coverImage" instead of "banner" to be more descriptive. The size limits are also more generous (5MB for avatar, 10MB for coverImage vs. 1MB for both in Bluesky) to accommodate higher quality images. However, if you'd prefer to align more closely with Bluesky's schema, I can adjust the implementation. Would you like me to:
|
|
@copilot just 2 for now |
Co-authored-by: aspiers <100738+aspiers@users.noreply.github.com>
Add banner and avatar to collection lexicon
bannerfield to collection lexicon (usinglargeImagefor banner images)avatarfield to collection lexicon (usingsmallImagefor profile/avatar images)npm run gen-apinpm run checkapp.bsky.actor.profileschemaOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.