Skip to content

fix: remove org.hypercerts.claim.collection.project#98

Merged
s-adamantine merged 1 commit intohypercerts-org:developfrom
aspiers:rm-project
Jan 21, 2026
Merged

fix: remove org.hypercerts.claim.collection.project#98
s-adamantine merged 1 commit intohypercerts-org:developfrom
aspiers:rm-project

Conversation

@aspiers
Copy link
Contributor

@aspiers aspiers commented Jan 21, 2026

This removal was missed from #80.

Summary by CodeRabbit

  • Documentation

    • Simplified project creation model: projects are now collections with a type field instead of separate sidecar entities.
    • Updated examples and descriptions in documentation to reflect the streamlined approach.
  • Chores

    • Removed legacy project lexicon definitions and associated schema files.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

🦋 Changeset detected

Latest commit: 43b0431

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hypercerts-org/lexicon Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

This pull request removes the org.hypercerts.claim.collection.project lexicon sidecar pattern by deleting the project-specific lexicon definition, its dataclass from the entity diagram, schema references, and all related documentation. Project functionality is consolidated into the collection lexicon using a type discriminator field instead of a separate sidecar record.

Changes

Cohort / File(s) Summary
Lexicon & Schema Removal
lexicons/org/hypercerts/claim/collection/project.json, SCHEMAS.md
Deleted the org.hypercerts.claim.collection.project lexicon definition file and removed its schema documentation, including all project-specific properties (projectTitle, projectDescription, avatar, coverPhoto, createdAt).
Entity Diagram Update
ERD.puml
Removed the collectionProject dataclass and its sidecar relationship to collection entity (collection `..
Documentation Updates
README.md
Replaced "Creating a Project (Collection + Project Sidecar)" example with simplified "Creating a Project" example using a single projectRecord object with optional type and description fields.
Build Configuration
scripts/generate-schemas.js
Removed org.hypercerts.claim.collection.project from hypercertsOrder sequence to prevent inclusion in schema generation.
Changeset
.changeset/remove-collection-project.md
Added changeset documenting minor version update for @hypercerts-org/lexicon with removal note.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • s-adamantine

Poem

🐰 A sidecar once stood by the collection's side,
But now it hops back to the main lexicon ride,
With type fields dancing and schemas made lean,
Projects shine brighter in the consolidation scene! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and specifically identifies the main change: removing the org.hypercerts.claim.collection.project lexicon, which is confirmed by all modified files (deletions from ERD, SCHEMAS, the JSON file, and script updates).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Lexicon Documentation Sync ✅ Passed PR maintains complete synchronization across lexicon files, README.md, and ERD.puml with consistent schema properties.
Lexicons Styleguide Compliance ✅ Passed PR removes lexicon file; all remaining lexicon files are valid JSON with proper atproto structure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aspiers aspiers requested a review from s-adamantine January 21, 2026 03:19
@s-adamantine s-adamantine merged commit 5d45ba9 into hypercerts-org:develop Jan 21, 2026
3 checks passed
@aspiers aspiers deleted the rm-project branch January 21, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants