Skip to content

Add roleNeededForApprover to shared settings configmap #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylervz merged 1 commit into from
Mar 21, 2025
Merged

Add roleNeededForApprover to shared settings configmap #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/thub/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.7.5
version: 1.7.6

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
3 changes: 3 additions & 0 deletions charts/thub/templates/shared-settings-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ data:
hclabs.ojt.blockAllTiles: {{ .Values.ojtBlockAllTiles | quote }}
hclabs.ojt.requireTotalHours: {{ .Values.ojtRequireTotalHours | quote }}
hclabs.onlySeeOjtsInYourOrganization: {{ .Values.onlySeeOjtsInYourOrganization | quote }}
{{- if .Values.roleNeededForApprover}}
hclabs.roleNeededForApprover: {{ .Values.roleNeededForApprover | quote }}
{{- end }}
hclabs.sfLearningHistoryConnectorTimeZone: {{ .Values.sfLearningHistoryConnectorTimeZone | quote }}
hclabs.sfLearningHistoryEsUserName: {{ .Values.sfLearningHistoryEsUserName | quote }}
hclabs.sfLearningHistoryLastUpdatedUser: {{ .Values.sfLearningHistoryLastUpdatedUser | quote }}
Expand Down
3 changes: 3 additions & 0 deletions charts/thub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ ojtRequireTotalHours: true
# This includes users who have a `null` `organizationID`; they can only see learners who also do not belong to an organization.
# However, if this is `true` and your user has `ROLE_OJT_FULL_ORG_VISIBILITY`, then you can see all the learners and OJTs.
onlySeeOjtsInYourOrganization: false
# Specify role here to override the default defined by the OJT application.yml
# In order for a Learner/User to be an approver for an OJT or OJTCourse, they need to have this specified role.
roleNeededForApprover: ""
# The timezone that SuccessFactors expects date and time values to be in the learning history connector input file.
# It is in a format that can be used by `java.util.TimeZone.getTimeZone()`. This value can be different for each client.
sfLearningHistoryConnectorTimeZone: "GMT"
Expand Down