Skip to content

Configure resources of the hyperdx-deployment initContainers #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Configure resources of the hyperdx-deployment initContainers #124

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f7bc37
Configure resources of the hyperdx-deployment initContainers
JaspreetSandhu Sep 24, 2025
c70def3
Add unit tests for hyperdx-deployment
JaspreetSandhu Sep 24, 2025
d221dd9
Check presence of nested keys
JaspreetSandhu Oct 5, 2025
50f382d
Merge branch 'main' into jaspreetsandhu/hyperdx-deployment/config-ini…
dhable Oct 6, 2025
22093cd
Update initContainer key name
JaspreetSandhu Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/hdx-oss-v2/templates/hyperdx-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ spec:
- name: wait-for-mongodb
image: busybox
command: ['sh', '-c', 'until nc -z {{ include "hdx-oss.fullname" . }}-mongodb {{ .Values.mongodb.port }}; do echo waiting for mongodb; sleep 2; done;']
{{- if .Values.hyperdx.initContainers.resources }}
Copy link
Collaborator

@dhable dhable Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a lot of test failures from this PR. It's stemming from this line when an initContainer isn't defined. The target of the resources property lookup is null and this crashes.

There is a function called dig that can provide safe access to nested properties while handling null values safely.

Copy link
Author

@JaspreetSandhu JaspreetSandhu Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you -- opted for hasKey for simplicity, and since there's no meaningful default value that I need if key isn't present. WDYT?

resources:
{{- toYaml .Values.hyperdx.initContainers.resources | nindent 12 }}
{{- end }}
{{- end }}
containers:
- name: app
Expand Down
34 changes: 33 additions & 1 deletion charts/hdx-oss-v2/tests/hyperdx-deployment_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,4 +269,36 @@ tests:
value: private-registry-secret
- lengthEqual:
path: spec.template.spec.imagePullSecrets
count: 3
count: 3

- it: should include initContainers resources when configured and mongodb is enabled
set:
mongodb:
enabled: true
hyperdx:
initContainers:
resources:
limits:
cpu: 1
memory: 1Gi
requests:
cpu: 2
memory: 2Gi
asserts:
- isNotEmpty:
path: spec.template.spec.initContainers
- equal:
path: spec.template.spec.initContainers[0].name
value: wait-for-mongodb
- isNotEmpty:
path: spec.template.spec.initContainers[0].resources
- equal:
path: spec.template.spec.initContainers[0].resources.limits
content:
cpu: 1
memory: 1Gi
- equal:
path: spec.template.spec.initContainers[0].resources.requests
content:
cpu: 2
memory: 2Gi
Loading