Skip to content

Commit 3978652

Browse files
committed
fix: close button now closes entire session drawer instead of navigating back
Separate onClose (closes drawer) from onNavigateToParent (back to session view) so the X button always dismisses the drawer while the back button navigates to the parent session. Made-with: Cursor
1 parent 3d12765 commit 3978652

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

packages/app/src/SessionSidePanel.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,8 @@ export default function SessionSidePanel({
199199
source={activeSourceEntry.source}
200200
rowId={activeSourceEntry.rowId}
201201
aliasWith={activeSourceEntry.aliasWith}
202-
onClose={() => setSourceStack(prev => prev.slice(0, -1))}
202+
onClose={handleClose}
203+
onNavigateToParent={() => setSourceStack([])}
203204
setSubDrawerOpen={setSubDrawerOpen}
204205
isFullWidth={isFullWidth}
205206
onToggleFullWidth={toggleFullWidth}

packages/app/src/components/DBRowSidePanel.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ export type DBRowSidePanelInnerProps = DBRowSidePanelProps & {
192192
onToggleFullWidth?: () => void;
193193
drawerSize?: number;
194194
parentBreadcrumbs?: BreadcrumbItem[];
195+
onNavigateToParent?: () => void;
195196
};
196197

197198
export const DBRowSidePanelInner = ({
@@ -205,6 +206,7 @@ export const DBRowSidePanelInner = ({
205206
onToggleFullWidth,
206207
drawerSize: _drawerSize,
207208
parentBreadcrumbs,
209+
onNavigateToParent,
208210
}: DBRowSidePanelInnerProps) => {
209211
const [sourceStack, setSourceStack] = useState<SourceStackEntry[]>([]);
210212
const [navStack, setNavStack] = useState<NavEntry[]>([]);
@@ -241,10 +243,12 @@ export const DBRowSidePanelInner = ({
241243
} else if (sourceStack.length > 0) {
242244
setSourceStack(prev => prev.slice(0, -1));
243245
setNavStack([]);
246+
} else if (onNavigateToParent) {
247+
onNavigateToParent();
244248
} else {
245249
onClose();
246250
}
247-
}, [navStack.length, sourceStack.length, onClose]);
251+
}, [navStack.length, sourceStack.length, onClose, onNavigateToParent]);
248252

249253
const handleSourceStackPush = useCallback((entry: SourceStackEntry) => {
250254
setSourceStack(prev => [...prev, entry]);

0 commit comments

Comments
 (0)