-
Notifications
You must be signed in to change notification settings - Fork 346
feat: add basepath config #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
datnguyennnx
wants to merge
4
commits into
hyperdxio:main
from
datnguyennnx:feat/add-basepath-support
Closed
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5b905c3
feat: add basepath config
datnguyennnx d69f875
docs: add changeset
datnguyennnx 007bf4f
feat(basepath): add runtime env support for subpath deployments
datnguyennnx 70fa0a7
fix(basepath): remove build-args from Makefile for runtime-only config
datnguyennnx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@hyperdx/app': minor | ||
| '@hyperdx/api': minor | ||
| '@hyperdx/common-utils': minor | ||
| --- | ||
|
|
||
| feat: Add basePath support for subpath deployments via environment variables |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| import { | ||
| getApiBasePath, | ||
| getFrontendBasePath, | ||
| getOtelBasePath, | ||
| joinPath, | ||
| } from '../basePath'; | ||
|
|
||
| describe('basePath utilities', () => { | ||
| describe('getFrontendBasePath', () => { | ||
| it('returns empty string if no env var', () => { | ||
| delete process.env.HYPERDX_BASE_PATH; | ||
| expect(getFrontendBasePath()).toBe(''); | ||
| }); | ||
|
|
||
| it('returns normalized path for valid input', () => { | ||
| process.env.HYPERDX_BASE_PATH = '/hyperdx'; | ||
| expect(getFrontendBasePath()).toBe('/hyperdx'); | ||
|
|
||
| process.env.HYPERDX_BASE_PATH = 'hyperdx/'; | ||
| expect(getFrontendBasePath()).toBe('/hyperdx'); | ||
|
|
||
| process.env.HYPERDX_BASE_PATH = '/hyperdx/'; | ||
| expect(getFrontendBasePath()).toBe('/hyperdx'); | ||
| }); | ||
|
|
||
| it('returns empty for invalid paths', () => { | ||
| process.env.HYPERDX_BASE_PATH = '/../invalid'; | ||
| expect(getFrontendBasePath()).toBe(''); | ||
|
|
||
| process.env.HYPERDX_BASE_PATH = 'http://example.com'; | ||
| expect(getFrontendBasePath()).toBe(''); | ||
| }); | ||
| }); | ||
|
|
||
| describe('getApiBasePath', () => { | ||
| it('defaults to /api if no env var', () => { | ||
| delete process.env.HYPERDX_API_BASE_PATH; | ||
| expect(getApiBasePath()).toBe('/api'); | ||
| }); | ||
|
|
||
| it('uses env var if set', () => { | ||
| process.env.HYPERDX_API_BASE_PATH = '/hyperdx/api'; | ||
| expect(getApiBasePath()).toBe('/hyperdx/api'); | ||
| }); | ||
|
|
||
| it('normalizes input', () => { | ||
| process.env.HYPERDX_API_BASE_PATH = 'hyperdx/api/'; | ||
| expect(getApiBasePath()).toBe('/hyperdx/api'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('getOtelBasePath', () => { | ||
| it('returns empty if no env var', () => { | ||
| delete process.env.HYPERDX_OTEL_BASE_PATH; | ||
| expect(getOtelBasePath()).toBe(''); | ||
| }); | ||
|
|
||
| it('returns normalized path', () => { | ||
| process.env.HYPERDX_OTEL_BASE_PATH = '/hyperdx/otel'; | ||
| expect(getOtelBasePath()).toBe('/hyperdx/otel'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('joinPath', () => { | ||
| it('joins empty base with relative', () => { | ||
| expect(joinPath('', '/test')).toBe('/test'); | ||
| }); | ||
|
|
||
| it('joins valid base and relative', () => { | ||
| expect(joinPath('/hyperdx', '/api')).toBe('/hyperdx/api'); | ||
| expect(joinPath('/hyperdx', 'api')).toBe('/hyperdx/api'); | ||
| }); | ||
|
|
||
| it('normalizes joined path', () => { | ||
| expect(joinPath('/hyperdx/', '/api/')).toBe('/hyperdx/api'); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean that devs need to rebuild the image whenever the env var changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wrn14897 No rebuild needed! Those build-args were a holdover from an earlier iteration - I've removed them entirely from the Makefile.
The base paths are now read at runtime via
process.envin centralized utils (basePath.ts), so you can switch subpaths dynamically withdocker run -e HYPERDX_BASE_PATH=/hyperdxor compose restart - no image rebuilds required. Verified: Build once (make build-app), run root → subpath via -e, and curls/UI/API prefix correctly (e.g., /hyperdx/api/health 200 OK).This aligns with your dynamic config concern. Please re-review—tests/E2E confirm no regressions!