fix: Update "Copy Object" in line viewer to work with nested objects and arrays #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arrays Fixes: HDX-2617
🦋 Changeset detectedLatest commit: d2faefa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code Review✅ No critical issues found. The fix correctly handles copying nested objects and arrays from parsed JSON contexts. The logic appropriately distinguishes between:
Test coverage is comprehensive with good test cases for:
Code follows project patterns and Mantine UI conventions. |
Contributor
E2E Test Results✅ All tests passed • 25 passed • 3 skipped • 227s
|
teeohhem
requested review from
a team and
pulpdrew
and removed request for
a team
teeohhem
commented
Oct 16, 2025
| JSON.stringify({ field3: 'nested value' }, null, 2), | ||
| ); | ||
| }); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Used TDD here to prove that the old functionality broke these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: HDX-2617