Skip to content

Fix bug where generated URLs default to live tail #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
+11 −2
Merged

Fix bug where generated URLs default to live tail #1326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25dd05f
Fix bug where generated URLs default to live tail
brandon-pereira Nov 4, 2025
e88af7c
Merge branch 'main' into brandon/fix-time-chart-live-tail
brandon-pereira Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/loud-spiders-share.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

Fix bug with generating search urls
5 changes: 4 additions & 1 deletion packages/app/src/DBSearchPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1108,11 +1108,14 @@ function DBSearchPage() {
to: searchedTimeRange[1].getTime().toString(),
select: searchedConfig.select || '',
source: searchedSource?.id || '',
filters: JSON.stringify(searchedConfig.filters),
filters: JSON.stringify(searchedConfig.filters ?? []),
isLive: 'false',
liveInterval: interval.toString(),
});
return `/search?${qParams.toString()}`;
},
[
interval,
searchedConfig.filters,
searchedConfig.select,
searchedConfig.where,
Expand Down
3 changes: 2 additions & 1 deletion packages/app/src/components/DBTimeChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ function DBTimeChartComponent({
source: (isMetricChart ? source?.logSourceId : source?.id) ?? '',
where: where,
whereLanguage: whereLanguage,
filters: JSON.stringify(config.filters),
filters: JSON.stringify(config.filters ?? []),
isLive: 'false',
Copy link
Member Author

@brandon-pereira brandon-pereira Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it would be nice to merge existing parameters into the URL, or to use the context to generate URL if available, but that would make this PR much bigger for minimal rewards

from: from.toString(),
to: to.toString(),
};
Expand Down
Loading