fix: Ensure displayed configs match queried configs in chart explorer #1527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 18d3916 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code Review✅ No critical issues found. The refactoring successfully centralizes config transformations to ensure displayed SQL/MV indicators match queried configs. The changes are well-tested and follow existing patterns. Minor observations:
The PR is ready to merge. |
Contributor
E2E Test Results✅ All tests passed • 55 passed • 4 skipped • 724s
Tests ran across 4 shards in parallel. |
pulpdrew
force-pushed
the
drew/fix-edit-chart-form-displayed-sql-explanations
branch
from
c9c4b97 to
bd559f1
Compare
pulpdrew
force-pushed
the
drew/fix-edit-chart-form-displayed-sql-explanations
branch
from
bd559f1 to
6979693
Compare
pulpdrew
requested review from
a team and
knudtty
and removed request for
a team
pulpdrew
force-pushed
the
drew/fix-edit-chart-form-displayed-sql-explanations
branch
from
6979693 to
f74deaf
Compare
knudtty
approved these changes
Jan 6, 2026
Comment on lines
-1230
to
+1273
| config={{ | ||
| ...queriedConfig, | ||
| granularity: alert | ||
| ? intervalToGranularity(alert.interval) | ||
| : queriedConfig.granularity, | ||
| dateRange: alert | ||
| ? extendDateRangeToInterval( | ||
| queriedConfig.dateRange, | ||
| alert.interval, | ||
| ) | ||
| : queriedConfig.dateRange, | ||
| }} | ||
| config={dbTimeChartConfig} |
Contributor
There was a problem hiding this comment.
Thank you for this wonderful performance improvement 🫡
kodiakhq
bot
deleted the
drew/fix-edit-chart-form-displayed-sql-explanations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HDX-3089
Closes HDX-3083
Summary
This PR ensures that the Generated SQL and Materialized View Explanations are generated for the same config that is queried.
Previously, this was not the case because child components (eg. DBTableChart, DBTimeChart, DBNumberChart) would transform the config passed down by DBEditTimeChart or Dashboard.Tile. Now, the same transformations are applied at the parent component.
Demo
Table Tile MV Indicator now correctly ignores granularity
Note that the time chart tiles cannot use MVs because the granularity is too small, but the table tile can use the MV:
Number and Table Chart generated SQL is correct
Number Chart has no granularity, group, or order by:
Table Chart has implicit group by, limit, and order by applied: