fix: Prevent dashboard infinite re-render #1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e97b5f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ No critical issues found. The fix correctly resolves the infinite re-render loop by:
The change is minimal, focused, and includes a proper changeset. |
Contributor
E2E Test Results✅ All tests passed • 51 passed • 4 skipped • 693s
Tests ran across 4 shards in parallel. |
teeohhem
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HDX-3117
Summary
This PR fixes a crash when loading or navigating away from the dashboard page. It occurred when a non-auto granularity was specified, and was caused by an infinite re-render loop due to continuously watching and resetting the granularity query parameter.
Before
Screen.Recording.2025-12-29.at.9.56.09.AM.mov
After
Screen.Recording.2025-12-29.at.9.55.32.AM.mov