Skip to content

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Dec 30, 2025

Summary

This PR fixes various minor style issues and inconsistencies throughout the app.

Changes

Consistent ... Button Size in DBEditTimeChart
Before Screenshot 2025-12-30 at 8 23 01 AM
After Screenshot 2025-12-30 at 8 19 09 AM
Add gap between DBEditTimeChart buttons
Before Screenshot 2025-12-30 at 8 25 54 AM
After Screenshot 2025-12-30 at 8 25 23 AM
Replace spinner-border with working loading indicators
Before (loading indicators missing) Screenshot 2025-12-30 at 8 32 34 AM
After Screenshot 2025-12-30 at 8 32 46 AM Screenshot 2025-12-30 at 8 43 25 AM Screenshot 2025-12-30 at 8 43 30 AM
Make histogram display switch consistent with other charts
Before Screenshot 2025-12-30 at 8 54 57 AM
After Screenshot 2025-12-30 at 8 54 24 AM
Make dashboard toolbar gaps consistent
Before Screenshot 2025-12-30 at 9 00 22 AM
After Screenshot 2025-12-30 at 8 59 16 AM
Make DBEditTimeChart play button margin consistent
Before Screenshot 2025-12-30 at 9 04 44 AM
After Screenshot 2025-12-30 at 9 03 31 AM

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2025

🦋 Changeset detected

Latest commit: 8f051c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Dec 30, 2025 5:02pm

@claude
Copy link

claude bot commented Dec 30, 2025

Code Review

✅ No critical issues found.

This PR successfully standardizes UI styling across dashboard components:

Good changes:

  • ✅ Replaced broken Bootstrap spinner-border with working Mantine IconRefresh + spin-animate (already exists in app.scss)
  • ✅ Removed redundant mr props on buttons - parent Flex with gap="sm" handles spacing correctly
  • ✅ Consistent display switcher pattern using ActionIcon with bg-muted styling (matches DBTimeChart.tsx)
  • ✅ Proper imports - all icons already imported in modified files

Minor notes (non-blocking):

  • Button size change from xs to sm in DBEditTimeChartForm.tsx:1155 is intentional for consistency
  • Unused imports cleaned up (SessionsPage.tsx) - good housekeeping

Ship it! 🚀

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

E2E Test Results

All tests passed • 52 passed • 5 skipped • 692s

Status Count
✅ Passed 52
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 5

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew marked this pull request as ready for review December 30, 2025 14:06
@pulpdrew pulpdrew changed the title style: Make DBEditTimeChart options button size consistent style: Fix minor style inconsistencies Dec 30, 2025
@pulpdrew pulpdrew changed the title style: Fix minor style inconsistencies style: Fix style inconsistencies Dec 30, 2025
@pulpdrew pulpdrew requested review from a team and dhable and removed request for a team December 30, 2025 14:36
@kodiakhq kodiakhq bot merged commit e78960f into main Dec 30, 2025
11 of 12 checks passed
@kodiakhq kodiakhq bot deleted the drew/style-nits branch December 30, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants