Skip to content

Conversation

@brandon-pereira
Copy link
Member

Reproduction:

  1. create a saved search with a custom select ex. Timestamp, Body
  2. go to another saved search with a default select (or anywhere with a default select)
  3. go back to initial saved search with custom select

Before: observe the SELECT statement is now the default select statement
After: observe that the SELECT statement is now updated as expected

Fixes HDX-3127

Reproduction:
1. create a saved search with a custom select ex. Timestamp, Body
2. go to another saved search with a default select (or anywhere with a default select)
3. go back to initial saved search with custom select

Before: observe the SELECT statement is now the default select statement
After: observe that the SELECT statement is now updated as expected

Fixes HDX-3127
@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2025

🦋 Changeset detected

Latest commit: af171b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Dec 30, 2025 5:45pm

@claude
Copy link

claude bot commented Dec 30, 2025

✅ No critical issues found.

The fix correctly addresses the race condition where useWatch returns undefined during form reset, causing the effect at line 1014-1040 to incorrectly trigger and override custom select values.

The defaultValue parameter ensures useWatch returns the correct value from searchedConfig.source during the reset cycle.

@github-actions
Copy link
Contributor

E2E Test Results

All tests passed • 52 passed • 5 skipped • 688s

Status Count
✅ Passed 52
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 5

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq kodiakhq bot merged commit 11bd8e3 into main Dec 30, 2025
14 checks passed
@kodiakhq kodiakhq bot deleted the brandon/fix-select-not-updating branch December 30, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants