Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: c6b071a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Knip - Unused Code Analysis⚪ No changes detected (182 issues on both main and PR) What is this?Knip finds unused files, dependencies, and exports in your codebase. Run |
PR Review
|
E2E Test Results✅ All tests passed • 103 passed • 3 skipped • 1032s
Tests ran across 4 shards in parallel. |
e39e4b7 to
93059ca
Compare
fc203a3 to
b170c22
Compare
b170c22 to
5422d25
Compare
5422d25 to
5a41a1b
Compare
5a41a1b to
c8fe7a7
Compare
c8fe7a7 to
35b517e
Compare
| variant="secondary" | ||
| data-testid="temp-dashboard-button" | ||
| > | ||
| Temporary |
There was a problem hiding this comment.
Hmm this feels a little odd.
Part of me feels like people will use the "New Dashboard" button without making the decision up front whether it needs to be persisted or not. Maybe the "New Dashboard" button could spawn a dropdown with a few options:
New Dashboard ▾
├── Saved Dashboard Persisted to your team and visible to all members
└── Temporary Dashboard → Lives in your browser only, not saved to your team
Thoughts?
There was a problem hiding this comment.
@teeohhem @pulpdrew, should we consider having all dashboards saved as “draft” by default, and let users publish them when they’re ready?
This is a common pattern across many products that involve saved states and collaboration. It removes the need for users to decide upfront whether something is temporary or meant for the team.
In this approach, everything is automatically saved as a draft. When the user is ready, they can explicitly publish it to make it available to others.
That said, I understand this might be tricky to implement at this stage.
There was a problem hiding this comment.
@teeohhem Updated, with slightly different wording to avoid having to change the wording in EE where RBAC will mean dashboards are not always visible to all team members.
@elizabetdev I think that's a good idea! Do you picture a "draft" dashboard being persisted but not shared with the team prior to publishing, or not persisted at all prior to publishing? The latter would be pretty straightforward to implement, the former is more similar to Shared/Private notebooks. I think though that either way, we should handle that as a separate issue/PR, if we're OK with that.
There was a problem hiding this comment.
I picture it as:
a "draft" dashboard being persisted but not shared with the team prior to publishing
Yes, it seems similar to shared/private notebooks. Handling this in a separate PR seems fine.
teeohhem
left a comment
There was a problem hiding this comment.
Just a few small comments. The design and implementation is very clean.
## Summary This PR introduces a new dashboards listing page, which lists the available dashboards. Each individual dashboard is no longer listed in the sidebar. The new listing page supports searching by name and filtering by tag. This PR is a continuation of @elizabetdev's #1805, with some changes, additional tests, and refactorings. This page does client-side sort and filter. There is no server-side pagination, filtering, or sorting. That is left as a future improvement, should it become necessary. ### Screenshots or video <img width="2556" height="794" alt="Screenshot 2026-03-24 at 7 45 54 AM" src="https://github.com/user-attachments/assets/e4c5dba0-6cdf-4f2a-a5f3-2e4e00979729" /> <img width="2553" height="842" alt="Screenshot 2026-03-24 at 7 45 43 AM" src="https://github.com/user-attachments/assets/fc0f5270-d6d3-47ff-be03-762abd82a7d1" /> <img width="2544" height="862" alt="Screenshot 2026-03-24 at 7 45 34 AM" src="https://github.com/user-attachments/assets/4b1957c3-0e6e-4910-ac66-830734604759" /> ### How to test locally or on Vercel The listing page can be tested in vercel preview. ### References - Linear Issue: Closes HDX-3565 - Related PRs:
## Summary This PR introduces a new dashboards listing page, which lists the available dashboards. Each individual dashboard is no longer listed in the sidebar. The new listing page supports searching by name and filtering by tag. This PR is a continuation of @elizabetdev's #1805, with some changes, additional tests, and refactorings. This page does client-side sort and filter. There is no server-side pagination, filtering, or sorting. That is left as a future improvement, should it become necessary. ### Screenshots or video <img width="2556" height="794" alt="Screenshot 2026-03-24 at 7 45 54 AM" src="https://github.com/user-attachments/assets/e4c5dba0-6cdf-4f2a-a5f3-2e4e00979729" /> <img width="2553" height="842" alt="Screenshot 2026-03-24 at 7 45 43 AM" src="https://github.com/user-attachments/assets/fc0f5270-d6d3-47ff-be03-762abd82a7d1" /> <img width="2544" height="862" alt="Screenshot 2026-03-24 at 7 45 34 AM" src="https://github.com/user-attachments/assets/4b1957c3-0e6e-4910-ac66-830734604759" /> ### How to test locally or on Vercel The listing page can be tested in vercel preview. ### References - Linear Issue: Closes HDX-3565 - Related PRs: Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
Summary
This PR introduces a new dashboards listing page, which lists the available dashboards. Each individual dashboard is no longer listed in the sidebar. The new listing page supports searching by name and filtering by tag. This PR is a continuation of @elizabetdev's #1805, with some changes, additional tests, and refactorings.
This page does client-side sort and filter. There is no server-side pagination, filtering, or sorting. That is left as a future improvement, should it become necessary.
Screenshots or video
How to test locally or on Vercel
The listing page can be tested in vercel preview.
References