fix: Improve auto-complete behavior for aliases and maps#1987
Merged
kodiakhq[bot] merged 3 commits intomainfrom Mar 25, 2026
Merged
fix: Improve auto-complete behavior for aliases and maps#1987kodiakhq[bot] merged 3 commits intomainfrom
kodiakhq[bot] merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f201673 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pulpdrew
changed the title
Contributor
Knip - Unused Code Analysis🔴 +2 change in total issues (231 on main → 233 on PR)
DetailsUnlisted dependencies
What is this?Knip finds unused files, dependencies, and exports in your codebase. Run |
Contributor
PR Review✅ No critical issues found. A few minor observations (non-blocking):
The logic is correct, well-scoped, and the test coverage for AS suppression and mid-identifier replacement range is solid. Safe to merge. |
Contributor
E2E Test Results✅ All tests passed • 93 passed • 3 skipped • 952s
Tests ran across 4 shards in parallel. |
pulpdrew
force-pushed
the
drew/fix-auto-complete-wonkiness
branch
from
091c0aa to
5b2411a
Compare
pulpdrew
requested review from
a team and
teeohhem
and removed request for
a team
teeohhem
approved these changes
Mar 25, 2026
Contributor
teeohhem
left a comment
teeohhem
left a comment
There was a problem hiding this comment.
Very slick. Confirmed working on my end
knudtty
pushed a commit
that referenced
this pull request
Apr 16, 2026
## Summary This PR improves auto-complete in the following ways 1. Auto-complete suggestions will not appear after `AS`, since it is assumed that a user will not want to type an existing column or function name as a column alias 2. Accepting an auto-complete suggestion will replace characters after the cursor if they match the accepted suggestion. This is nice when, for example, I have typed `ResourceAttributes[]` and my cursor is before the `]` - accepting a suggestion will now replace the trailing `]` instead of leaving it be (in which case it would be duplicated after inserting the suggestion). ### Screenshots or video https://github.com/user-attachments/assets/9577393c-6bfa-410b-b5ba-2ba6b00bc26b ### How to test locally or on Vercel This can be tested in the preview environment. ### References - Linear Issue: Closes HDX-2612 - Related PRs:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves auto-complete in the following ways
AS, since it is assumed that a user will not want to type an existing column or function name as a column aliasResourceAttributes[]and my cursor is before the]- accepting a suggestion will now replace the trailing]instead of leaving it be (in which case it would be duplicated after inserting the suggestion).Screenshots or video
Screen.Recording.2026-03-25.at.9.06.55.AM.mov
How to test locally or on Vercel
This can be tested in the preview environment.
References