fix: Restore some react-hook lint rules

[pulpdrew]

Summary

This PR:

• Updates the eslint config to restore some react-hook plugin rules which were inadvertently removed without being replaced 1:1 in chore: Add @eslint-react/eslint-plugin recommended rules #2069
• Reverts chore: automatic fixes from the linter #2074, as those lint fixes were possible only because the related rules had been removed

Rule equivalence is documented here: https://www.eslint-react.xyz/docs/migrating-from-eslint-plugin-react-hooks

You can view current effective rule states with cd packages/app && npx eslint --inspect-config

How to test locally or on Vercel

Locally:

make ci-lint / make dev-lint

References

• Linear Issue: HDX-3467
• Related PRs:

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Apr 9, 2026 4:03pm

[changeset-bot]

⚠️ No Changeset found

Latest commit: 84062ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats

• Files changed: 17
• Lines changed: 55
• Branch: drew/lint-restore
• Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

[github-actions]

PR Review

• ⚠️ 'react-hooks/set-state-in-render': 'error' may not exist in eslint-plugin-react-hooks v7 — the standard stable rules are rules-of-hooks and exhaustive-deps. If this rule name is invalid, ESLint silently ignores it and the setState-in-render protection is absent. Verify with npx eslint --print-config src/index.tsx | grep set-state or check the plugin's exported rules object.

• ⚠️ react-hooks/rules-of-hooks is disabled (critical React correctness rule) — the comment says @eslint-react's recommended-type-checked covers it, but this should be explicitly verified. Run npx eslint --inspect-config and confirm an equivalent rule (e.g. @eslint-react/rules-of-hooks) is enabled and error-level before merging.

• ℹ️ // eslint-disable-next-line react-hooks/refs on return statement lines (useTableSearch.ts:148, timeQuery.ts:347) is unusual placement — these suppress the rule for the entire object literal returned, not a specific ref access. Acceptable if intentional, but worth confirming the suppression scope is correct.

[github-actions]

E2E Test Results

❌ 12 tests failed • 120 passed • 3 skipped • 1186s

Status	Count
✅ Passed	120
❌ Failed	12
⚠️ Flaky	1
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →