Skip to content

chore: don't include test files in line count changes for pr tiering#2083

Merged
kodiakhq[bot] merged 2 commits intomainfrom
tom/tier-test-changes
Apr 9, 2026
Merged

chore: don't include test files in line count changes for pr tiering#2083
kodiakhq[bot] merged 2 commits intomainfrom
tom/tier-test-changes

Conversation

@teeohhem
Copy link
Copy Markdown
Contributor

@teeohhem teeohhem commented Apr 9, 2026

Previously test files contributed to the line count of PRs, possibly elevating their tier unintentionally.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026

⚠️ No Changeset found

Latest commit: 9c5b75a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

🔴 Tier 4 — Critical

Touches auth, data models, config, tasks, OTel pipeline, ClickHouse, or CI/CD.

Why this tier:

  • Critical-path files (1):
    • .github/workflows/pr-triage.yml

Review process: Deep review from a domain expert. Synchronous walkthrough may be required.
SLA: Schedule synchronous review within 2 business days.

Stats
  • Files changed: 1
  • Lines changed: 13
  • Branch: tom/tier-test-changes
  • Author: teeohhem

To override this classification, remove the review/tier-4 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions github-actions bot added the review/tier-4 Critical — deep review + domain expert sign-off label Apr 9, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Apr 9, 2026 3:43pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

PR Review

✅ No critical issues found.

The change is correct and well-scoped: test file patterns cover the main conventions used in this repo (__tests__/, .test.ts(x), .spec.ts(x), packages/app/tests/), the testLines variable is computed and surfaced in the stats comment for transparency, and the logic is straightforward inline JS in the workflow script — consistent with the existing style.

One minor observation (not a blocker): the testLines intermediate variable is computed with a second .filter() pass over filesRes — this could be derived as totalLines - linesChanged to avoid the double iteration, but at PR-triage scale this is inconsequential.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

E2E Test Results

All tests passed • 131 passed • 3 skipped • 1027s

Status Count
✅ Passed 131
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq kodiakhq bot merged commit d866e99 into main Apr 9, 2026
17 checks passed
@kodiakhq kodiakhq bot deleted the tom/tier-test-changes branch April 9, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-4 Critical — deep review + domain expert sign-off

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants