feat: Add between and not-between alert thresholds

[pulpdrew]

Summary

This PR adds BETWEEN and NOT BETWEEN alert threshold types.

Screenshots or video

How to test locally or on Vercel

This must be tested locally, since alerts are not supported in the preview environment.

To see the notification content, run an echo server locally and create a webhook that targets it (http://localhost:3000):

npx http-echo-server

References

• Linear Issue: Closes HDX-3988
• Related PRs:

[changeset-bot]

🦋 Changeset detected

Latest commit: 2aafb7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@hyperdx/otel-collector	Patch
@hyperdx/common-utils	Patch
@hyperdx/api	Patch
@hyperdx/app	Patch
@hyperdx/cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Apr 17, 2026 11:03am

[github-actions]

🔴 Tier 4 — Critical

Touches auth, data models, config, tasks, OTel pipeline, ClickHouse, or CI/CD.

Why this tier:

• Critical-path files (3):
  • packages/api/src/routers/external-api/v2/alerts.ts
  • packages/api/src/tasks/checkAlerts/index.ts
  • packages/api/src/tasks/checkAlerts/template.ts
• Cross-layer change: touches frontend (packages/app) + backend (packages/api) + shared utils (packages/common-utils)

Review process: Deep review from a domain expert. Synchronous walkthrough may be required.
SLA: Schedule synchronous review within 2 business days.

Stats

• Production files changed: 20
• Production lines changed: 350 (+ 1659 in test files, excluded from tier calculation)
• Branch: drew/between-thresholds
• Author: pulpdrew

To override this classification, remove the review/tier-4 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

[github-actions]

PR Review

This PR is well-implemented with validation at multiple layers (Zod schemas, form-level, API), comprehensive test coverage (unit, integration, E2E), and consistent handling across all surfaces. No critical issues found.

---

• ⚠️ doesExceedThreshold throws for missing thresholdMax but there is no visible try-catch wrapping the call sites in processAlert. The test 'should not fire or record history when thresholdMax is missing' passes because existing broader error handling in processAlert swallows the exception — this is implicit, brittle behavior. Consider returning false (no alert) instead of throwing when thresholdMax is absent, which makes the safe-default explicit and removes the dependency on ambient error suppression.

• ⚠️ thresholdMax is not cleared when the user switches from a range type (e.g. between) back to a single-threshold type (e.g. above) in both TileAlertEditor and DBSearchPageAlertModal. The stale value persists in the form and gets submitted to the API. The API ignores it (validation only checks for range types), but the value is stored in MongoDB unnecessarily. A small setValue('thresholdMax', undefined) in the onChange handler for non-range types would clean this up.

• ✅ Removal of isBuilderSavedChartConfig guards in AppNav.tsx and DashboardsListPage.tsx is safe — the downstream .filter(a => a != null) handles undefined alert fields, and these were pre-existing patterns tightened in this PR.

• ✅ describeThreshold fallback '?' for missing thresholdMax is a reasonable defensive guard for the template rendering path.

[github-actions]

E2E Test Results

✅ All tests passed • 146 passed • 3 skipped • 1058s

Status	Count
✅ Passed	146
❌ Failed	0
⚠️ Flaky	3
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →

[pulpdrew]

Fixes bug: dashboards with alerts on raw sql tiles were not showing up with an alert indicator on the appnav