Skip to content

Conversation

@Tebarem
Copy link
Collaborator

@Tebarem Tebarem commented Oct 11, 2025

Fix for #931

@github-actions github-actions bot added the fix label Oct 11, 2025
@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  19.5 ns ...  19.6 ns ]      +0.46%
ray_intersection/aabb_size_1                       [  19.2 ns ...  19.3 ns ]      +0.21%
ray_intersection/aabb_size_10                      [  19.2 ns ...  19.1 ns ]      -0.27%
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      -0.04%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      -0.20%
ray_intersection/ray_distance_20                   [   3.8 ns ...   3.8 ns ]      +0.29%
overlap/no_overlap                                 [  28.6 ns ...  28.6 ns ]      +0.11%
overlap/partial_overlap                            [  28.9 ns ...  28.8 ns ]      -0.23%
overlap/full_containment                           [  21.6 ns ...  21.6 ns ]      +0.28%
point_containment/inside                           [   4.9 ns ...   4.9 ns ]      +0.23%
point_containment/outside                          [   4.4 ns ...   4.5 ns ]      +0.76%
point_containment/boundary                         [   5.0 ns ...   5.0 ns ]      +0.04%

Comparing to 313503c

@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 0% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.19%. Comparing base (313503c) to head (f1377c2).

Files with missing lines Patch % Lines
crates/hyperion/src/simulation/inventory.rs 0.00% 60 Missing ⚠️
@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
- Coverage   23.28%   23.19%   -0.09%     
==========================================
  Files         157      157              
  Lines       15505    15565      +60     
  Branches      486      496      +10     
==========================================
  Hits         3610     3610              
- Misses      11794    11854      +60     
  Partials      101      101              
Files with missing lines Coverage Δ
crates/hyperion/src/simulation/inventory.rs 6.42% <0.00%> (-0.39%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  19.2 ns ...  19.2 ns ]      -0.23%
ray_intersection/aabb_size_1                       [  19.2 ns ...  19.2 ns ]      +0.15%
ray_intersection/aabb_size_10                      [  19.3 ns ...  19.2 ns ]      -0.24%
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      -0.21%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      -0.13%
ray_intersection/ray_distance_20                   [   3.8 ns ...   3.8 ns ]      +0.14%
overlap/no_overlap                                 [  28.6 ns ...  28.7 ns ]      +0.26%
overlap/partial_overlap                            [  28.8 ns ...  28.8 ns ]      +0.05%
overlap/full_containment                           [  21.6 ns ...  21.6 ns ]      +0.17%
point_containment/inside                           [   4.9 ns ...   4.9 ns ]      +0.05%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      +0.03%
point_containment/boundary                         [   5.0 ns ...   5.0 ns ]      +0.06%

Comparing to 313503c

@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  19.2 ns ...  19.3 ns ]      +0.22%
ray_intersection/aabb_size_1                       [  19.3 ns ...  19.3 ns ]      -0.06%
ray_intersection/aabb_size_10                      [  19.5 ns ...  19.6 ns ]      +0.06%
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      -0.06%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      -0.15%
ray_intersection/ray_distance_20                   [   3.8 ns ...   3.8 ns ]      -0.15%
overlap/no_overlap                                 [  29.2 ns ...  29.2 ns ]      +0.13%
overlap/partial_overlap                            [  29.1 ns ...  29.1 ns ]      -0.08%
overlap/full_containment                           [  22.0 ns ...  22.0 ns ]      +0.03%
point_containment/inside                           [   5.0 ns ...   5.0 ns ]      -0.00%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      +0.25%
point_containment/boundary                         [   5.2 ns ...   5.2 ns ]      -0.09%

Comparing to 313503c

This reverts commit fe35213.
@github-actions
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  19.3 ns ...  19.2 ns ]      -0.36%
ray_intersection/aabb_size_1                       [  19.2 ns ...  19.2 ns ]      +0.05%
ray_intersection/aabb_size_10                      [  19.2 ns ...  19.2 ns ]      -0.15%
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      -0.43%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      -0.07%
ray_intersection/ray_distance_20                   [   3.8 ns ...   3.8 ns ]      -0.06%
overlap/no_overlap                                 [  37.9 ns ...  28.8 ns ]     -24.00%*
overlap/partial_overlap                            [  38.1 ns ...  28.8 ns ]     -24.36%*
overlap/full_containment                           [  30.3 ns ...  21.6 ns ]     -28.78%*
point_containment/inside                           [   5.1 ns ...   5.0 ns ]      -1.54%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      -0.23%
point_containment/boundary                         [   4.9 ns ...   4.9 ns ]      -0.06%

Comparing to 313503c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants