Handle implicit resets at the right time#833
Merged
seanmonstar merged 1 commit intomasterfrom Jan 24, 2025
Merged
Conversation
nox
force-pushed
the
fix-implicit-reset
branch
2 times, most recently
from
dffce7f to
38ebb1b
Compare
seanmonstar
reviewed
Jan 20, 2025
nox
force-pushed
the
fix-implicit-reset
branch
3 times, most recently
from
7420a99 to
9b85baf
Compare
Contributor
Author
|
I simplified the change a lot by just gating the |
A stream whose ref count reaches zero while open should not immediately decrease the number of active streams, otherwise MAX_CONCURRENT_STREAMS isn't respected anymore.
nox
force-pushed
the
fix-implicit-reset
branch
from
9b85baf to
b9b0c91
Compare
seanmonstar
approved these changes
Jan 24, 2025
GlenDC
added a commit
to plabayo/rama
that referenced
this pull request
Feb 20, 2025
* Fix reclaiming reserved capacity (fixes <hyperium/h2#607>) by @nox in <hyperium/h2#832> * Fix busy loop on shutdown by @seanmonstar in <hyperium/h2#834> * Fix window size decrement of send-closed streams by @nox in <hyperium/h2#830> * Fix handle implicit resets at the right time by @nox in <hyperium/h2#833> * Fix poll_flush after poll_shutdown by @bdbai in <hyperium/h2#836> Co-authored-by: Sean McArthur <sean@seanmonstar.com> Co-authored-by: 包布丁 <htbai1998m@hotmail.com> Co-authored-by: Anthony Ramine <123095+nox@users.noreply.github.com> Co-authored-by: Samuel Tardieu <sam@rfc1149.net>
AhmedSoliman
added a commit
to restatedev/restate
that referenced
this pull request
Jun 17, 2025
More importantly, fixes a bug where h2 was miscounting the number of open streams causing h2 servers to kill connections (fixed in hyperium/h2#833)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stream whose ref count reaches zero while open should not immediately decrease the number of active streams, otherwise MAX_CONCURRENT_STREAMS isn't respected anymore.