Skip to content

Make StatusCode::from_u16 const #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make StatusCode::from_u16 const #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/status.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,13 @@ impl StatusCode {
/// assert!(err.is_err());
/// ```
#[inline]
pub fn from_u16(src: u16) -> Result<StatusCode, InvalidStatusCode> {
if !(100..1000).contains(&src) {
return Err(InvalidStatusCode::new());
pub const fn from_u16(src: u16) -> Result<StatusCode, InvalidStatusCode> {
if let 100..=999 = src {
if let Some(code) = NonZeroU16::new(src) {
return Ok(StatusCode(code));
}
}

NonZeroU16::new(src)
.map(StatusCode)
.ok_or_else(InvalidStatusCode::new)
Err(InvalidStatusCode::new())
}

/// Converts a `&[u8]` to a status code.
Expand Down Expand Up @@ -523,7 +522,7 @@ status_codes! {
}

impl InvalidStatusCode {
fn new() -> InvalidStatusCode {
const fn new() -> InvalidStatusCode {
InvalidStatusCode { _priv: () }
}
}
Expand Down