Skip to content

chore: further simplify BufList::copy_to_bytes #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tisonkun wants to merge 2 commits into from
Closed

chore: further simplify BufList::copy_to_bytes #3889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd03960
chore: further simplify BufList::copy_to_bytes
tisonkun May 16, 2025
0e201e8
Update buf.rs
tisonkun May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/common/buf.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,7 @@ impl<T: Buf> Buf for BufList<T> {
// Our inner buffer may have an optimized version of copy_to_bytes, and if the whole
// request can be fulfilled by the front buffer, we can take advantage.
match self.bufs.front_mut() {
Some(front) if front.remaining() == len => {
let b = front.copy_to_bytes(len);
self.bufs.pop_front();
b
}
Some(front) if front.remaining() == len => self.bufs.pop_front().unwrap(),
Some(front) if front.remaining() > len => front.copy_to_bytes(len),
_ => {
assert!(len <= self.remaining(), "`len` greater than remaining");
Expand Down
Loading