Drop dependency on futures-channel #3951
Closed
+19
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhyNotHugo
force-pushed
the
futures-channel
branch
from
e923921 to
9f4b7d0
Compare
Contributor
Author
|
v2: applied cargo fmt |
WhyNotHugo
force-pushed
the
futures-channel
branch
from
9f4b7d0 to
a547aab
Compare
Contributor
Author
|
Odd, there are some failures which didn't come up locally. I'll leave this as draft until I've resolve these. |
Contributor
|
The API of futures-channel is somewhat different from Tokio’s channel. Doesn’t it need to be changed? |
Contributor
Author
|
Message ID: ***@***.***>Yeah, but it seems I tested without the relevant features enabled. I’ll iterate further and un-draft this when it’s ready.
|
Contributor
Author
|
We're relying on Receiver implementing Stream, which tokio's doesn't. I don't think this change is feasible. Sorry for the noise. |
Tokio already provides mpsc and oneshot, and it is an unconditional dependency. Use those implementations and drop a superfluous dependency.
WhyNotHugo
force-pushed
the
futures-channel
branch
from
a547aab to
b12f119
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokio already provides mpsc and oneshot, and it is an unconditional dependency. Use those implementations and drop a superfluous dependency.