Skip to content

feat: Allow MAX_URI_LEN configuration via environment variable #3959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −2
Open

feat: Allow MAX_URI_LEN configuration via environment variable #3959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/proto/h1/role.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,23 @@ use crate::proto::h1::{
use crate::proto::RequestHead;
use crate::proto::{BodyLength, MessageHead, RequestLine};

#[cfg(feature = "server")]
use std::sync::OnceLock;
pub(crate) const DEFAULT_MAX_HEADERS: usize = 100;
const AVERAGE_HEADER_SIZE: usize = 30; // totally scientific
#[cfg(feature = "server")]
const MAX_URI_LEN: usize = (u16::MAX - 1) as usize;
const DEFAULT_MAX_URI_LEN: usize = (u16::MAX - 1) as usize;

#[cfg(feature = "server")]
fn max_uri_len() -> usize {
static MAX_URI_LEN: OnceLock<usize> = OnceLock::new();
*MAX_URI_LEN.get_or_init(|| {
std::env::var("HYPER_MAX_URI_LEN")
.ok()
.and_then(|s| s.parse().ok())
.unwrap_or(DEFAULT_MAX_URI_LEN)
})
}

macro_rules! header_name {
($bytes:expr) => {{
Expand Down Expand Up @@ -169,7 +182,7 @@ impl Http1Transaction for Server {
trace!("Request.parse Complete({})", parsed_len);
len = parsed_len;
let uri = req.path.unwrap();
if uri.len() > MAX_URI_LEN {
if uri.len() > max_uri_len() {
return Err(Parse::UriTooLong);
}
method = Method::from_bytes(req.method.unwrap().as_bytes())?;
Expand Down