Keyword handlers: Added four new keywordHandlers #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
requested changes
Aug 4, 2025
Collaborator
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
This is just a partial review so far. I think I've gotten through everything except the "unevaluated" keywords.
| { | ||
| valid: false, | ||
| absoluteKeywordLocation: "https://example.com/main#/propertyNames/pattern", | ||
| instanceLocation: "#*/Foo" |
Collaborator
There was a problem hiding this comment.
This is an interesting case because the * notation isn't standard. Let's make a note to discuss how we want to handle this keyword.
Collaborator
Author
There was a problem hiding this comment.
I also get confused when i saw this instanceLocation. Noted to discuss it later.
Collaborator
Author
|
Corrected all the errors. |
jdesrosiers
reviewed
Aug 4, 2025
Collaborator
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
I think the unevaluated keywords are going to need a different approach. Let's remove those from this PR and let's discuss how to handle those keywords in our next pairing session.
jdesrosiers
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.