Add deduplication function for host entries#281
Open
dviejokfs wants to merge 1 commit intohyperledger-bevel:mainfrom
Open
Add deduplication function for host entries#281dviejokfs wants to merge 1 commit intohyperledger-bevel:mainfrom
dviejokfs wants to merge 1 commit intohyperledger-bevel:mainfrom
Conversation
…ollers - Introduced a new `deduplicateHosts` function in both `ordnode_controller.go` and `peer_controller.go` to eliminate duplicate host entries from enrollment requests. - Updated relevant functions to utilize this new deduplication logic, ensuring cleaner and more efficient host management during certificate enrollment and renewal processes. These changes enhance the reliability of host handling in the application, preventing potential issues caused by duplicate entries. Signed-off-by: dviejokfs <dviejo@kfs.es>
| }, nil | ||
| } | ||
|
|
||
| func deduplicateHosts(hosts []string) []string { |
Contributor
There was a problem hiding this comment.
[nitpick]: looks good, this function can be moved to utils to avoid duplication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deduplicateHostsfunction in bothordnode_controller.goandpeer_controller.goto eliminate duplicate host entries from enrollment requests.These changes enhance the reliability of host handling in the application, preventing potential issues caused by duplicate entries.