Skip to content

docs(satp-hermes): fix docs diagrams path in package.json#4103

Closed
AndreAugusto11 wants to merge 1 commit intohyperledger-cacti:mainfrom
AndreAugusto11:fix-satp-docs-paths
Closed

docs(satp-hermes): fix docs diagrams path in package.json#4103
AndreAugusto11 wants to merge 1 commit intohyperledger-cacti:mainfrom
AndreAugusto11:fix-satp-docs-paths

Conversation

@AndreAugusto11
Copy link
Member

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Signed-off-by: André Augusto <andre.augusto@tecnico.ulisboa.pt>
@AndreAugusto11
Copy link
Member Author

@RafaelAPB we should compile all the diagrams and put them in packages/cactus-plugin-satp-hermes/docs/assets/diagrams. As of now, there are only 3 there, and the https://github.com/hyperledger-cacti/cacti/blob/main/packages/cactus-plugin-satp-hermes/docs/architecture/satp-hermes.md is showing the placeholders. I'm not able to generate them using mmdc for some reason...

@AndreAugusto11
Copy link
Member Author

already solved in #4101

@AndreAugusto11 AndreAugusto11 deleted the fix-satp-docs-paths branch February 10, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant