Fix deleteAgent API call message always succeeds#691
Merged
yeasy merged 6 commits intohyperledger-cello:mainfrom Jun 30, 2025
Merged
Conversation
Previously, deleteCallback always showed a success message regardless of whether the deleteAgent API call succeeded or failed. Now it checks response.success before showing the message and only displays a success message when the API call is successful. An error message is shown otherwise. This prevents misleading user feedback in case of deletion failure. Signed-off-by: dodo920306 <dodo920306@gmail.com>
Contributor
Author
|
The build for this may also fail because the |
Contributor
Author
|
Also, shall we also combine https://github.com/hyperledger-cello/cello/pull/691/files#diff-403672fc815d806b49ea96bfe9925b72deba54aaba8301d41f86f16ffbeb75ffR286-L285 if (userRole === 'admin') {
dispatch({
type: 'agent/deleteAgent',
payload: agent.id,
callback: this.deleteCallback,
});
} else {
dispatch({
type: 'agent/deleteAgent',
payload: agent.id,
callback: this.deleteCallback,
});
}because they do the same thing? |
YoungHypo
approved these changes
Jun 20, 2025
…hecking-the-result
…hecking-the-result
…hecking-the-result
…hecking-the-result
…hecking-the-result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, deleteCallback always showed a success message regardless of whether the deleteAgent API call succeeded or failed.
Now it checks response.success before showing the message and only displays a success message when the API call is successful. An error message is shown otherwise.
This prevents misleading user feedback in case of deletion failure.