feat: multiple splice versions #855
Conversation
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
…uble-splice-version-test Signed-off-by: Pawel Stepien <[email protected]> # Conflicts: # scripts/src/lib/utils.ts
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
…uble-splice-version-test Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
Signed-off-by: Pawel Stepien <[email protected]>
…uble-splice-version-test Signed-off-by: Pawel Stepien <[email protected]>
|
|
||
| - name: Download Canton | ||
| run: yarn script:fetch:canton | ||
| run: yarn script:fetch:canton --network=mainnet |
There was a problem hiding this comment.
i would suggest to add a comment here to remove the network enforcement once we have upgraded the bootstrap script to support canton 3.4
| timeout 5m bash -c ' | ||
| LOGFILE=canton_start.log | ||
| yarn start:canton > "$LOGFILE" 2>&1 & | ||
| yarn start:canton --network=mainnet > "$LOGFILE" 2>&1 & |
| name: docker-logs-${{ matrix.network }} | ||
| path: logs/ | ||
|
|
||
| test-wallet-sdk-e2e: |
There was a problem hiding this comment.
do we need this ? seems like a task that just echos ?
There was a problem hiding this comment.
Other than echo, test-wallet-sdk-e2e has "needs: sdk-e2e" where we have 2 runs for mainnet and devnet (with different names). So it aggregates 2 jobs passing ("sdk-e2e (mainnet)", "sdk-e2e (devnet)") to one "test-wallet-sdk-e2e"
Branch protection rules are for single "test-wallet-sdk-e2e".
We could remove this aggregation step it if we updated branch protection rules to expect something like both:
test-wallet-sdk-e2e (mainnet)
test-wallet-sdk-e2e (devnet)
| '#canton-builtin-admin-workflow-ping:Canton.Internal.Ping:Ping' | ||
| const version = sdk.userLedger!.getCurrentClientVersion() | ||
| const isNewTemplate = greaterOrEqualVersion(version, '3.4') | ||
| const myTemplateId = isNewTemplate ? PING_NEW : PING_OLD |
There was a problem hiding this comment.
while this is a cool way to solve it would probably just change the templateId to use the string for holdings 😅
There was a problem hiding this comment.
right, I overcomplicated it a bit :)
Signed-off-by: Pawel Stepien <[email protected]>
No description provided.