Soroban: Add extendTtl Builtin Method #1709
Soroban: Add extendTtl Builtin Method #1709salaheldinsoliman merged 12 commits intohyperledger-solang:mainfrom
extendTtl Builtin Method #1709Conversation
a8de760 to
384437c
Compare
|
Update: Tests for all storage types have been added in |
extendPersistentTtl Builtin Method extendTtl Builtin Method
salaheldinsoliman
left a comment
There was a problem hiding this comment.
Great!
Looks good but could you please:
1- Sign your commits for the DCO to pass
2- Add a test under integration/soroban?
384437c to
1542bfd
Compare
Signed-off-by: Tarek <tareknaser360@gmail.com>
Signed-off-by: Tarek <tareknaser360@gmail.com>
Signed-off-by: Tarek <tareknaser360@gmail.com>
Signed-off-by: Tarek <tareknaser360@gmail.com>
Signed-off-by: Tarek <tareknaser360@gmail.com>
Signed-off-by: Tarek <tareknaser360@gmail.com>
…sions Signed-off-by: Tarek <tareknaser360@gmail.com>
Signed-off-by: Tarek <tareknaser360@gmail.com>
Signed-off-by: Tarek <tareknaser360@gmail.com>
Signed-off-by: Tarek <tareknaser360@gmail.com>
1542bfd to
0020820
Compare
Sure, should be fixed now
This is a bit tricky. Writing integration tests for the time-to-live functionality would require a way to access the current ledger state during tests (like we do now in There’s a package For now, I’d like to get this PR through, and in a follow-up PR, I’ll add support for other variable types in |
fe96d0d
into
hyperledger-solang:main
This PR adds support for
extendPersistentTtl()method in Soroban, along with a test and documentation. Also, the Soroban testing infrastructure has been refactored to allow more flexible environment manipulation.Documentation for
extend_ttlFixes #1669
Changes
extendPersistentTtlas a method onuint64for the Soroban target.extend_ttlis a generic function (IntoVal<Env, Val>)but Solidity does not support that, so it's implemented as a method instead.
different_storage_typestest is affected due to changes in diagnostic capture. A follow-up PR will address this.