Refactor Soroban decoding/encoding logic#1752
Merged
salaheldinsoliman merged 23 commits intohyperledger-solang:mainfrom Mar 15, 2025
Merged
Refactor Soroban decoding/encoding logic#1752salaheldinsoliman merged 23 commits intohyperledger-solang:mainfrom
salaheldinsoliman merged 23 commits intohyperledger-solang:mainfrom
Conversation
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
salaheldinsoliman
requested review from
LucasSte,
seanyoung and
xermicus
as code owners
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
salaheldinsoliman
changed the title
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
salaheldinsoliman
merged commit 279ee91
into
hyperledger-solang:main
17 of 18 checks passed
ahmadsamehh
pushed a commit
to ahmadsamehh/solang
that referenced
this pull request
Mar 20, 2025
This PR aims to do the following: 1- Add a proper framework for Soroban encoding/decoding scheme (https://github.com/stellar/stellar-protocol/blob/master/core/cap-0046-01.md), so it is easier for further contributions to support other types. 2- Add support for integers of bit-width 128, to serve as an example for other contributions. --------- Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu> Add support for type Uint32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to do the following:
1- Add a proper framework for Soroban encoding/decoding scheme (https://github.com/stellar/stellar-protocol/blob/master/core/cap-0046-01.md), so it is easier for further contributions to support other types.
2- Add support for integers of bit-width 128, to serve as an example for other contributions.