Check command statuses in build.rs#1778
Merged
seanyoung merged 3 commits intohyperledger-solang:mainfrom May 11, 2025
Merged
Conversation
Signed-off-by: Samuel Moelius <sam@moeli.us>
smoelius
requested review from
LucasSte,
salaheldinsoliman,
seanyoung and
xermicus
as code owners
Contributor
Author
|
I'm assuming the CI failures are not due to this PR. Please tell met if that is incorrect. |
seanyoung
approved these changes
May 10, 2025
Contributor
seanyoung
left a comment
seanyoung
left a comment
There was a problem hiding this comment.
Good addition - I've hit this problem too and it's not obvious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1684 by checking the statuses of two commands in the build.rs file.
I never actually received a response to #1684. So I won't be insulted if the PR is rejected as unnecessary.