Implement Soroban integer width rounding feature (#1805)#1810
Merged
salaheldinsoliman merged 12 commits intohyperledger-solang:mainfrom Aug 24, 2025
Merged
Conversation
…1805) Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
guptapratykshh
requested review from
LucasSte,
salaheldinsoliman,
seanyoung and
xermicus
as code owners
Contributor
|
@guptapratykshh It looks good, but will need some |
…cs tests Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
Contributor
Author
|
Added the test cases for the integer width rounding feature @salaheldinsoliman Please look into this |
Contributor
|
@guptapratykshh You need to make sure tests are passing. Some CI tests will fail, like VSCode, polkadot and anchor integration tests |
…fined_variable_detection test Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
guptapratykshh
force-pushed
the
soroban-integer-width-rounding
branch
from
f57b10c to
08fba39
Compare
Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
…havior Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
Contributor
Author
|
Please look into this @salaheldinsoliman |
Contributor
|
@guptapratykshh Tests are still failing, could you make sure they pass by running |
…nalyzer behavior Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
Contributor
Author
|
@salaheldinsoliman All the test have been passed and i have also checked it locally. Please have a look at it |
| generate_debug_information: false, | ||
| log_runtime_errors: false, | ||
| log_prints: true, | ||
| strict_soroban_types: false, |
Contributor
There was a problem hiding this comment.
@guptapratykshh Looks good now, however why is that file changed?
This seems not related to this PR
Contributor
Author
There was a problem hiding this comment.
made the change please look into this @salaheldinsoliman
guptapratykshh
force-pushed
the
soroban-integer-width-rounding
branch
from
30e435e to
8a1f00b
Compare
…detection test Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
guptapratykshh
force-pushed
the
soroban-integer-width-rounding
branch
from
8a1f00b to
ce62df8
Compare
Contributor
Author
|
Plaese look into this , i think everything is sorted in this PR @salaheldinsoliman |
salaheldinsoliman
approved these changes
Aug 24, 2025
salaheldinsoliman
merged commit c63cfcc
into
hyperledger-solang:main
15 of 17 checks passed
guptapratykshh
added a commit
to guptapratykshh/pg-solang
that referenced
this pull request
Nov 16, 2025
…1805) (hyperledger-solang#1810) ## Description This PR adds automatic rounding of integer widths to Soroban-compatible sizes when developers use unsupported integer types like `int56` or `uint72`. ### Key Changes Automatic Rounding - int56 → int64, uint72 → uint128, etc. Warning Messages - Shows exact warnings for non-compatible widths Strict Mode Flag - `--strict-soroban-types` turns warnings into errors Soroban-Only - Only applies when targeting Soroban runtime Fixes hyperledger-solang#1805 --------- Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com> Co-authored-by: salaheldinsoliman <49910731+salaheldinsoliman@users.noreply.github.com> Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds automatic rounding of integer widths to Soroban-compatible sizes when developers use unsupported integer types like
int56oruint72.Key Changes
Automatic Rounding - int56 → int64, uint72 → uint128, etc.
Warning Messages - Shows exact warnings for non-compatible widths
Strict Mode Flag -
--strict-soroban-typesturns warnings into errorsSoroban-Only - Only applies when targeting Soroban runtime
Fixes #1805