Fix: propagate strict_soroban_types and re-enable soroban_testcases#1835
Merged
salaheldinsoliman merged 2 commits intohyperledger-solang:mainfrom Oct 3, 2025
Merged
Conversation
Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
guptapratykshh
requested review from
salaheldinsoliman and
seanyoung
as code owners
Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
guptapratykshh
force-pushed
the
soroban-int-width-fresh
branch
from
e2ea0cc to
2a9a0f4
Compare
Contributor
Author
|
@salaheldinsoliman i have re-enabled |
salaheldinsoliman
approved these changes
Oct 3, 2025
salaheldinsoliman
merged commit c07ac96
into
hyperledger-solang:main
27 of 33 checks passed
guptapratykshh
added a commit
to guptapratykshh/pg-solang
that referenced
this pull request
Nov 16, 2025
…yperledger-solang#1835) 1. Propagate Options.strict_soroban_types into Namespace so Soroban integer-width rounding diagnostics are emitted correctly. 2. Re-enable tests/soroban.rs module soroban_testcases under #[cfg(feature = "soroban")]. --------- Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.