Silence mismatched_lifetime_syntaxes lint#1837
Merged
salaheldinsoliman merged 2 commits intohyperledger-solang:mainfrom Oct 18, 2025
Merged
Silence mismatched_lifetime_syntaxes lint#1837salaheldinsoliman merged 2 commits intohyperledger-solang:mainfrom
mismatched_lifetime_syntaxes lint#1837salaheldinsoliman merged 2 commits intohyperledger-solang:mainfrom
Conversation
smoelius
requested review from
salaheldinsoliman and
seanyoung
as code owners
Signed-off-by: Samuel Moelius <samuel.moelius@trailofbits.com>
smoelius
force-pushed
the
mismatched-lifetime-syntaxes
branch
from
015e477 to
ac066d9
Compare
Contributor
Author
|
@salaheldinsoliman Thank you very much for reviewing my PR. I get the impression that the original maintainers are not very active these days. I presume you cannot merge this PR (or any PR) alone---is that correct? If so, do you think the |
salaheldinsoliman
merged commit e2b90b2
into
hyperledger-solang:main
13 of 17 checks passed
Contributor
|
Hi @smoelius, |
Contributor
Author
|
Thanks, @salaheldinsoliman! |
guptapratykshh
pushed a commit
to guptapratykshh/pg-solang
that referenced
this pull request
Nov 16, 2025
I think the PR name is self-explanatory. Signed-off-by: Samuel Moelius <samuel.moelius@trailofbits.com> Co-authored-by: salaheldinsoliman <49910731+salaheldinsoliman@users.noreply.github.com> Signed-off-by: Pratyksh Gupta <pratykshgupta9999@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the PR name is self-explanatory.