Static libs and jar artifact for boringssl #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public final String error; | ||
|
|
||
| // Wrapper result classes - use common implementations | ||
| public static class P256VerifyResult extends BoringSSLPrecompilesCommon.P256VerifyResult { |
Check notice
Code scanning / CodeQL
Class has same name as super class Note
garyschulte
force-pushed
the
poc/static-libs-for-boringssl
branch
2 times, most recently
from
98f6b3f to
4e072a4
Compare
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
garyschulte
force-pushed
the
poc/static-libs-for-boringssl
branch
from
4e072a4 to
6ed554a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295
This PR adds a new artifact to besu-native builds for p256_verify in boringssl - a static lib, and graal specific classes which enable static compilation. This artifacts target static compilation in order to support besu zkvm guest program development.
This PR builds on top of #297, and should be reviewed/merged after in order to reduce review burden
Subsequent libraries will be delivered incrementally in a similar fashion.
This PR explicitly does not add tests for the static artifacts, since graal is required. However, tests for the gnark static lib exist in besu-zkvm