Skip to content

Use SyncTransactionReceipt in SNAP sync #9621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Matilda-Clerke wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Use SyncTransactionReceipt in SNAP sync #9621

Matilda-Clerke wants to merge 27 commits into from

Conversation

@Matilda-Clerke
Copy link
Contributor

@Matilda-Clerke Matilda-Clerke commented Jan 12, 2026

PR description

Utilise SyncTransactionReceipt to avoid unnecessary processing and memory usage during SNAP sync

@Matilda-Clerke
Add SyncTransactionReceipt, decoder, and update LogsBloomFilter to ut…
d720d0e 
…ilise raw Bytes

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Add unit test for LogBloomFilter changes
a03a97e 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Merge branch 'main' into add-synctransactionreceipt
3b0a626
@Matilda-Clerke
Fix missing parentheses in comment in SyncTransactionReceiptDecoder
2068ec9 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Improve unit testing for SyncTransactionReceiptDecoder
67da819 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Improve unit testing for SyncTransactionReceiptDecoder
1dc15bb 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Use random hashes for stateRoot in SyncTransactionReceiptDecoderTest
98da6ba 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Merge branch 'main' into add-synctransactionreceipt
0b4d957
@Matilda-Clerke
Merge branch 'main' into add-synctransactionreceipt
f7bdc72
@Matilda-Clerke
Utilise SyncTransactionReceipt in SNAP sync
4776815 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Fix sync tests
f5388d2 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Spotless
03bed9a 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Merge branch 'main' into add-synctransactionreceipt
02ee182
@Matilda-Clerke
Merge branch 'add-synctransactionreceipt' into use-synctransactionrec…
bf77275 
…eipt-in-snap-sync
@Matilda-Clerke
Fix ReceiptsMessage.syncReceipts
15ced45 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Use cumulativeGasUsed instead of cumulativeGas
ad09745 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Use cumulativeGasUsed instead of cumulativeGas
3a00e6a 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Allow variables in SyncTransactionReceipt to be cleared
52e76c9 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Merge branch 'add-synctransactionreceipt' into use-synctransactionrec…
785bddf 
…eipt-in-snap-sync
@Matilda-Clerke
Fix formatting issue
c9de7c0 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Merge branch 'add-synctransactionreceipt' into use-synctransactionrec…
1ddad07 
…eipt-in-snap-sync
@Matilda-Clerke
Update to accomodate merged changes
638313f 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Fix compile issues
f2f23a7 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Merge branch 'add-synctransactionreceipt' into use-synctransactionrec…
d7369f6 
…eipt-in-snap-sync
@Matilda-Clerke Matilda-Clerke marked this pull request as ready for review January 14, 2026 01:35
@Matilda-Clerke
Copy link
Contributor Author

Matilda-Clerke commented Jan 14, 2026

Initial testing shows on-par performance with snap sync on main, so I'm opening this up for review. Please understand that this PR extends from 9574 so will reduce slightly in size once 9574 is merged

@Matilda-Clerke
Copy link
Contributor Author

Matilda-Clerke commented Jan 15, 2026

9574 has now been merged to main, and main merge to this branch

@Matilda-Clerke
Delete now unused GetReceiptsForHeadersTask
ea2a8d2 
Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>
@Matilda-Clerke
Merge remote-tracking branch 'origin/use-synctransactionreceipt-in-sn…
475ab4c 
…ap-sync' into use-synctransactionreceipt-in-snap-sync
@jframe
Copy link
Contributor

jframe commented Jan 15, 2026

Initial testing shows on-par performance with snap sync on main, so I'm opening this up for review. Please understand that this PR extends from 9574 so will reduce slightly in size once 9574 is merged

What is the memory usage during sync compare some control nodes, is it less? Can you share JVM memory usage and GC time.

@Matilda-Clerke
Copy link
Contributor Author

Matilda-Clerke commented Jan 19, 2026

Comparing
syn-transaction-receipt-338-with-expanded-fields
with
transaction-receipt-expanded
I'm not sure this PR will result in any significant change in memory usage. Curious what others think

@macfarla macfarla moved this to Open PRs in 26.1.0 Release Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinges pinges Awaiting requested review from pinges

@jframe jframe Awaiting requested review from jframe

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

26.1.0 Release
Status: Open PRs

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Matilda-Clerke @jframe