public apis for end-to-end tests #222
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdingly. Signed-off-by: Bill Quayle <[email protected]>
Author
|
@bestbeforetoday @SamYuan1990 |
Author
|
@bestbeforetoday Since you are the author of the issue that this PR aims to address, can you please point me to what I need to do to move this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address issue 207 by introducing two new functions on the channel api (UpdateChannelConfig and CreateGenesisBlock) that allow the tests in test/e2e_test.go and test/channel_test.go to be written without calls to internal functions. These two test codes are rewritten to use these functions; a little bit of the ensuing reorganization affects other files (e.g. the SignConfigTx function has been moved from test/e2e_suite_test.go to internal/util/util.go).