Skip to content

Conversation

@anushka159-a
Copy link
Contributor

I have modified the current Dockerfile to be able to generate a Production grade Docker Image based on UBI, the new Dockerfile follows the below good practices for Production.

Multi-stage build: keeps the final image small and clean.
Non-root execution: creates appuser (uid 10001) and runs the service as non-root.
Minimal runtime dependencies: no extra tools/packages installed (keeps attack surface small).
Metadata labels: provides traceability (name, version, maintainer, vendor, etc.).
Deterministic build: dependencies are pulled in the build stage, final image only has the binary.
Absolute path: in ENTRYPOINT: safer for production.

@cendhu cendhu requested a review from pasquale95 November 21, 2025 10:32
@pasquale95
Copy link
Contributor

@anushka159-a please enhance the Dockerfile and .dockerignore files to follow the guidelines we discussed during our sync.

@pasquale95
Copy link
Contributor

pasquale95 commented Dec 23, 2025

@cendhu I've updated the PR with some improvements. I have a couple of questions:

  • the Docker README is outdated and technically not necessary anymore since it refers to internal IBM procedures. Should we remove it with this PR?
  • the docker-compose is also outdated as it refers to when the images were splitted. I suggest to either remove or update it. If you're ok with removing it, i can do it with this PR.
  • I see in many code places that by default the version 0.0.2 is referred. Is this intended or should they point always to the latest?

pasquale95
pasquale95 previously approved these changes Dec 23, 2025
Copy link
Contributor

@pasquale95 pasquale95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT
Not true. Pipeline failed.

@pasquale95 pasquale95 self-requested a review December 23, 2025 08:11
@pasquale95 pasquale95 dismissed their stale review December 23, 2025 08:12

Pipeline failing on new prod-ready images.

Copy link
Contributor

@pasquale95 pasquale95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pasquale95 pasquale95 requested a review from cendhu January 6, 2026 10:21
@cendhu cendhu merged commit 5463682 into hyperledger:main Jan 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants