-
Notifications
You must be signed in to change notification settings - Fork 11
Adding support for production grade image in Dockerfile #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for production grade image in Dockerfile #180
Conversation
Signed-off-by: Anushka <[email protected]>
Signed-off-by: Anushka <[email protected]>
Signed-off-by: Anushka <[email protected]>
Signed-off-by: Anushka <[email protected]>
Signed-off-by: Anushka <[email protected]>
|
@anushka159-a please enhance the |
Signed-off-by: pco <[email protected]>
|
@cendhu I've updated the PR with some improvements. I have a couple of questions:
|
Signed-off-by: pco <[email protected]>
Signed-off-by: pco <[email protected]>
Signed-off-by: pco <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
Not true. Pipeline failed.
Pipeline failing on new prod-ready images.
Signed-off-by: pco <[email protected]>
Signed-off-by: pco <[email protected]>
Signed-off-by: pco <[email protected]>
Signed-off-by: pco <[email protected]>
Signed-off-by: pco <[email protected]>
pasquale95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: pco <[email protected]>
Signed-off-by: pco <[email protected]>
Signed-off-by: pco <[email protected]>
I have modified the current Dockerfile to be able to generate a Production grade Docker Image based on UBI, the new Dockerfile follows the below good practices for Production.
Multi-stage build: keeps the final image small and clean.
Non-root execution: creates appuser (uid 10001) and runs the service as non-root.
Minimal runtime dependencies: no extra tools/packages installed (keeps attack surface small).
Metadata labels: provides traceability (name, version, maintainer, vendor, etc.).
Deterministic build: dependencies are pulled in the build stage, final image only has the binary.
Absolute path: in ENTRYPOINT: safer for production.