-
Notifications
You must be signed in to change notification settings - Fork 11
Introduce support for MSP load generation #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7896a4e to
6d3aca3
Compare
6d3aca3 to
57a9c29
Compare
d44ac20 to
bda241b
Compare
bda241b to
a5daf90
Compare
|
|
||
| // PeerOrganizationCount may specify the number of peer organizations to generate if the CryptoMaterialPath | ||
| // is not provided. | ||
| PeerOrganizationCount uint32 `mapstructure:"peer-organization-count"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that CreateConfigBlockWithCrypto always uses TwoOrgsSampleFabricX profile. What does 4 peer organization count means in two org profile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is nothing special about TwoOrgsSampleFabricX.
We need a sample that has the following main ingredients.
SomeSample:
<<: *ChannelDefaults
Orderer:
<<: *OrdererDefaults
OrdererType: arma
Organizations:
- <<: *SomeOrg
Application: *ApplicationDefaultsWe need at least one organization as a template org to create all the organizations. Currently, we use the first Orderer-organization.
So a sample with no Application-organizations will also work fine.
The alternative is to use the default value for everything (from the sample file) and let the user specify the template organization to use from the sample file.
This can improve clarity as to what is taken from the sample file.
This CreateDefaultConfigBlockWithCrypto() method (from the common repo) is already tailored for Fabric-X, so it would be a stretch to use ARMA's and the scalable-committer's default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It is good to be clear about what is being used from the sample file. I admit I’ve forgotten why TwoOrgsSampleFabricX is used here, given I reviewed the PR that handled crypto material creation along with the config block before vacation.
| MetaNamespaceVerificationKey: metaPolicy.GetThresholdRule().GetPublicKey(), | ||
| OrdererEndpoints: policy.OrdererEndpoints, | ||
| ChannelID: policy.ChannelID, | ||
| PeerOrganizationCount: policy.PeerOrganizationCount, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the relation between TwoOrgsProfile and PeerOrganizationCount?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using TwoOrgsProfile does not affect the number of peer organizations that will be created. It is only decided by PeerOrganizationCount.
Signed-off-by: Liran Funaro <[email protected]>
Signed-off-by: Liran Funaro <[email protected]>
a5daf90 to
8dfe812
Compare
cendhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Type of change
Description
Additional Info
Following is the micro benchmark for endorsing and verifying with the MSP using 3 peer organizations.
Related issues