[test] Fix race condition when accessing command buffer output#447
Merged
cendhu merged 1 commit intohyperledger:mainfrom Mar 19, 2026
Merged
[test] Fix race condition when accessing command buffer output#447cendhu merged 1 commit intohyperledger:mainfrom
cendhu merged 1 commit intohyperledger:mainfrom
Conversation
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Root cause: The test was experiencing a race condition when accessing command output buffers. In
UnitTestRunner, the command execution runs in a goroutine that continuously writes output tobytes.Bufferinstances (cmdStdOut and cmdStdErr), while simultaneously another goroutine inassert.Eventuallyreads from these buffers viacmdStdOut.String()to check for expected output. Sincebytes.Bufferis not thread-safe for concurrent read/write operations, this caused data races detected by the race detector when multiple goroutines accessed the buffer simultaneously.Related issues