[prometheus] Separate prometheus server startup from service logic#523
Draft
dean-amar wants to merge 3 commits intohyperledger:mainfrom
Draft
[prometheus] Separate prometheus server startup from service logic#523dean-amar wants to merge 3 commits intohyperledger:mainfrom
dean-amar wants to merge 3 commits intohyperledger:mainfrom
Conversation
…tartup lifecycle. * Removed unused code. Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
dean-amar
changed the title
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
cendhu
reviewed
Apr 9, 2026
| // StartMonitoringServer starts the Prometheus monitoring server. | ||
| // This method blocks until the server exits or the context is cancelled. | ||
| // Monitoring server errors are logged but do not cause the service to stop. | ||
| StartMonitoringServer(ctx context.Context) error |
Contributor
There was a problem hiding this comment.
StartMonitoringServer is starting a http server. I am not sure whether this should be part of grpcservice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR refactors the Prometheus monitoring server startup logic across all services to improve code organization and lifecycle management. Previously, each service started its monitoring server internally within its Run() method.
Now, monitoring server lifecycle is explicitly managed separately from service logic.
Related issues