[block-store] return ErrNotFound instead of default error type#90
Merged
cendhu merged 2 commits intohyperledger:mainfrom Mar 9, 2026
Merged
[block-store] return ErrNotFound instead of default error type#90cendhu merged 2 commits intohyperledger:mainfrom
cendhu merged 2 commits intohyperledger:mainfrom
Conversation
cendhu
force-pushed
the
return-not-found-blk-store
branch
from
639d0bb to
61dbd46
Compare
Currently, the committer sends NotFound grpc error code for block APIs by parsing the error message. As this is fragile, this commit adds ErrNotFound error so that the committer can use errors.Is(). Signed-off-by: Senthilnathan <cendhu@gmail.com>
cendhu
force-pushed
the
return-not-found-blk-store
branch
from
61dbd46 to
e024a4e
Compare
liran-funaro
approved these changes
Mar 9, 2026
Signed-off-by: Senthilnathan <cendhu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Currently, the committer sends NotFound grpc error code for block APIs by parsing the error message. As this is fragile, this commit adds ErrNotFound error so that the committer can use errors.Is().
Related issues