Refactor net utils #489
Merged
Refactor net utils #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HagarMeir
reviewed
Jan 5, 2026
common/utils/net.go
Outdated
| "google.golang.org/grpc/peer" | ||
| ) | ||
|
|
||
| func ExtractCertificateFromContext(ctx context.Context) *x509.Certificate { // TODO add unit test |
Contributor
Author
There was a problem hiding this comment.
No, I just moved the code. We'll deal with this later...
Contributor
There was a problem hiding this comment.
look at TestExtractCertificateFromContext
Refactor net utilities to a leaf package because they will create a cycle in the next commit. Signed-off-by: Yoav Tock <[email protected]>
HagarMeir
approved these changes
Jan 5, 2026
moradna
pushed a commit
to moradna/fabric-x-orderer
that referenced
this pull request
Jan 7, 2026
Refactor net utilities to a leaf package because they will create a cycle in the next commit. Signed-off-by: Yoav Tock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor net utilities to a leaf package because they will create a cycle in the next commit.
Move three methods from
nodepackage tocommon/utilspackage.