Remove gossip concepts from deliver client#613
Merged
HagarMeir merged 1 commit intohyperledger:mainfrom Feb 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes gossip-related concepts from the deliver client codebase, which is part of an effort to clean up orderer code. The changes align with the PR title "Remove gossip concepts from deliver client" and focus on eliminating gossip service adapters and related SmartBFT configuration utilities that were marked as TODO items for removal.
Changes:
- Removed the
ConfigFromMetadataOptionsfunction and related SmartBFT imports fromutil.go - Deleted the auto-generated
GossipServiceAdapterfake implementation - Removed the
GossipServiceAdapterinterface definition fromdeliverer.go - Updated comments to reflect orderer-specific behavior instead of peer/gossip behavior
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| node/consensus/synchronizer/util.go | Removed unused ConfigFromMetadataOptions function and imports for SmartBFT types and gossip-related protos |
| common/deliverclient/blocksprovider/fake/gossip_service_adapter.go | Deleted auto-generated fake implementation for GossipServiceAdapter interface |
| common/deliverclient/blocksprovider/deliverer.go | Removed GossipServiceAdapter interface definition and updated comment to focus on orderer behavior |
| common/deliverclient/blocksprovider/block_receiver.go | Updated BlockHandler interface comments to clarify peer and orderer responsibilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Yoav Tock <tock@il.ibm.com>
tock-ibm
force-pushed
the
deliver-client-remove-gossip
branch
from
9453629 to
d8619b2
Compare
HagarMeir
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.