Test configuration update - Change party TLS/Sign certs#645
Open
gengur wants to merge 1 commit intohyperledger:mainfrom
Open
Test configuration update - Change party TLS/Sign certs#645gengur wants to merge 1 commit intohyperledger:mainfrom
gengur wants to merge 1 commit intohyperledger:mainfrom
Conversation
gengur
force-pushed
the
change_party_certs
branch
from
5c748e9 to
4fd90ae
Compare
gengur
changed the title
gengur
changed the title
HagarMeir
force-pushed
the
change_party_certs
branch
from
4fd90ae to
e78b8b0
Compare
HagarMeir
reviewed
Feb 24, 2026
HagarMeir
reviewed
Feb 24, 2026
config/config.go
Outdated
| } | ||
|
|
||
| if !bytes.Equal(localTLSCert, sharedBatcherConfig.TlsCert) { | ||
| if !utils.AreCertificatesEqual(localTLSCert, sharedBatcherConfig.TlsCert) { |
Contributor
There was a problem hiding this comment.
why use this func and not bytes.Equal?
HagarMeir
reviewed
Feb 24, 2026
HagarMeir
reviewed
Feb 24, 2026
HagarMeir
reviewed
Feb 24, 2026
HagarMeir
reviewed
Feb 24, 2026
gengur
force-pushed
the
change_party_certs
branch
4 times, most recently
from
2331799 to
92e1da0
Compare
tock-ibm
force-pushed
the
change_party_certs
branch
from
92e1da0 to
fc460cd
Compare
Signed-off-by: Genady Gurevich <genadyg@il.ibm.com>
HagarMeir
force-pushed
the
change_party_certs
branch
from
fc460cd to
a0ce978
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push the configuration update and verify it was applied successfully.
Change party tls/sign certificates
issue #247