testing(fxconfig): add TLS to integration tests#63
Open
remo-lab wants to merge 1 commit intohyperledger:mainfrom
Open
testing(fxconfig): add TLS to integration tests#63remo-lab wants to merge 1 commit intohyperledger:mainfrom
remo-lab wants to merge 1 commit intohyperledger:mainfrom
Conversation
Signed-off-by: remo-lab <remopanda7@gmail.com>
Author
|
@mbrandenburger @pasquale95 , please let me know your thoughts on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adds TLS coverage to the fxconfig integration tests. Previously the tests only ran with
--insecure. This change parameterizes the tests so they run in two modes:none(existing behavior)tls(server-side TLS)Ephemeral certificates are generated during the test using
tlsgen, and copied into the test-node container using the same layout expected by the committer (/server-certs/and/client-certs/). The fxconfig client config is updated to include the generated CA so secure gRPC connections can be established.All existing scenarios are now executed under both modes without duplicating test logic.
Implementation notes
tlsModes := []string{"none", "tls"}and parameterized the integration tests witht.Runhelpers_test.goto generate temporary TLS credentials and configure the containertlsmode the test container runs without--insecureand allSC_*_TLS_MODEenv vars are set totlstls:section withenabled: trueand the generated CATest plan
go vet ./tools/fxconfig/...go test ./tools/fxconfig/internal/...nonemode (regression check)tlsmode validating secure gRPC connectionsRelated issues
Closes #62